Fix the duplicate calendar events bug #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ap0nia
requested changes
Nov 30, 2023
EricPedley
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
since this is a bugfix, imma just merge it real quick. @ap0nia if u want anything else to be refactored we can do it in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change fixes the bug caused by looping over events' location.days when the calendarizeHelper has already returned events for each day.
For example, class A occurs every MWF, the calendarizeHelper returns (event for Monday) -> {..., location: {..., days: "MWF"}}, also events for Wednesday and Friday with the same location field.
Therefore, we will finally get 3*3=9 calendar events.
Finals are also added repetitively.
Test Plan
Passed the vite test. Also tested manually.
Issues
Closes #816